fix: ensure regex character classes aren't used for single char (#87)

techpivot · Oct 26, 2024 · 79bd587 · 79bd587
1 parent 42fabc2
commit 79bd587
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/pull-request.ts b/src/pull-request.ts
@@ -214,7 +214,7 @@ export async function getPullRequestCommits(): Promise<CommitDetails[]> {
 export async function addReleasePlanComment(
   terraformChangedModules: TerraformChangedModule[],
   terraformModuleNamesToRemove: string[],
-  wikiStatus: { status: WikiStatus; errorMessage?: string | undefined },
+  wikiStatus: { status: WikiStatus; errorMessage?: string },
 ): Promise<void> {
   console.time('Elapsed time commenting on pull request');
   startGroup('Adding pull request release plan comment');

diff --git a/src/wiki.ts b/src/wiki.ts
@@ -271,11 +271,11 @@ async function updateWikiSidebar(terraformModules: TerraformModule[]): Promise<v
         const heading = headingMatch[1].trim();
 
         // Convert heading into a valid ID string (keep only [a-zA-Z0-9-_]) But we need spaces to go to a '-'
-        const idString = heading.replace(/[ ]+/g, '-').replace(/[^a-zA-Z0-9-_]/g, '');
+        const idString = heading.replace(/ +/g, '-').replace(/[^a-zA-Z0-9-_]/g, '');
 
         // Append the entry to changelogEntries
         changelogEntries.push(
-          `            <li><a href="${baselink}#${idString}">${heading.replace(/[`]/g, '')}</a></li>`,
+          `            <li><a href="${baselink}#${idString}">${heading.replace(/`/g, '')}</a></li>`,
         );
       }