Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added a basic regex tester page. #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nikhilmaske-2001
Copy link

Part of #72
Basic regex test feature is implemented in this PR

Screenshot from 2023-09-09 13-03-02
Screenshot from 2023-09-09 13-02-51

@HariKrishna-28 HariKrishna-28 requested review from vaibhav-kaushal and removed request for vaibhav-kaushal September 9, 2023 09:31
Copy link
Contributor

@HariKrishna-28 HariKrishna-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to request the following changes

  • Please make sure to use alerts for the messages on the right so that it stays consistent with the overall user interface.
  • Also please display the strings that matches the pattern on the right and highlight them on the input field as well.
  • Please add a lorem ipsum text as the initial value for the input field and also a simple regex pattern on the regex input field.
  • Please add a copy button to copy the regex pattern and make sure that it stays consistent with the existing user interface. You could refer other components for reference.

Copy link
Contributor

@HariKrishna-28 HariKrishna-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to request the following changes

  • Please make the text area resizable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants