Add detailed buttons to various games #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://discord.com/channels/284830696860680192/644289322194829321/835901635276177408 I might reverse these changes or edit them slightly before opening a PR but who knows
BBCS2 does not detect buttons 5 and 6 at all, even in test mode, and are thus unlabeled. BBCF, similarly, does not detect button 5, and is unlabeled.
Button 3 is listed but marked Unused for purity's sake. The input test menu still recognises the button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more descriptive button labels to games previously labeled generically like "Button 1", "Button 2", etc.. It also fixes some typos in existing labels, as well as removing the "Player 1" prefix on buttons for games that are single player only. For games with multiple control schemes, such as BBCF, buttons were labeled with the generic labels given by the game itself, such as "A", "B", "C", etc.. Most games with unused buttons (some fighting games and NesicaXLive games) had their InputMappings removed. See here for more information on this decision. Most commits with special cases will have descriptions describing the exact details.