Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve lighthouse score (also bumped deps) #54

Merged
merged 6 commits into from
Oct 1, 2022
Merged

improve lighthouse score (also bumped deps) #54

merged 6 commits into from
Oct 1, 2022

Conversation

elianiva
Copy link
Member

@elianiva elianiva commented Oct 1, 2022

image

@elianiva elianiva added the enhancement New feature or request label Oct 1, 2022
@elianiva elianiva requested review from aldy505 and ii64 October 1, 2022 04:21
@elianiva elianiva self-assigned this Oct 1, 2022
@aldy505
Copy link
Member

aldy505 commented Oct 1, 2022

udah di tes buat mobile sama desktop?

@elianiva
Copy link
Member Author

elianiva commented Oct 1, 2022 •
edited
Loading

ini mobile

image

kurang gzip/brotli compression, tapi ntar aja deh, mending nunggu lukeed/polka#148 daripada nulis sendiri

@aldy505
Copy link
Member

aldy505 commented Oct 1, 2022

gzip/brotli bisa diatur dari traefik jadi middleware. https://doc.traefik.io/traefik/middlewares/http/compress/

@elianiva
Copy link
Member Author

elianiva commented Oct 1, 2022

perlu ganti minResponseBodyBytes juga ngga?

@aldy505
Copy link
Member

aldy505 commented Oct 1, 2022

perlu. didaftarin juga si compress middleware ini ke list route middleware. cek line atasnya

@aldy505 aldy505 merged commit 6ee098a into master Oct 1, 2022
@aldy505 aldy505 deleted the fix/a11y-lang branch October 1, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 approved these changes

@ii64 ii64 Awaiting requested review from ii64

Assignees

@elianiva elianiva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elianiva @aldy505