create build type constants

tektoncd · Aug 7, 2023 · d9f0026 · d9f0026
1 parent 98fc220
commit d9f0026
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go b/pkg/chains/formats/slsa/v2alpha2/internal/build_definitions/build_definitions.go
@@ -0,0 +1,6 @@
+package builddefinitions
+
+const (
+	SlsaBuildType   = "https://tekton.dev/chains/v2/slsa"
+	TektonBuildType = ""
+)
diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go b/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go
@@ -28,9 +28,7 @@ import (
 const (
 	pipelineRunResults = "pipelineRunResults/%s"
 	// JsonMediaType is the media type of json encoded content used in resource descriptors
-	JsonMediaType   = "application/json"
-	slsaBuildType   = "https://tekton.dev/chains/v2/slsa"
-	tektonBuildType = ""
+	JsonMediaType = "application/json"
 )
 
 // GenerateAttestation generates a provenance statement with SLSA v1.0 predicate for a pipeline run.
@@ -110,14 +108,14 @@ func byproducts(pro *objects.PipelineRunObject) ([]slsa.ResourceDescriptor, erro
 
 func getBuildDefinition(buildType string, pro *objects.PipelineRunObject) (builddefinitions.PipelineBuildType, error) {
 	switch buildType {
-	case slsaBuildType:
+	case builddefinitions.SlsaBuildType:
 		return builddefinitions.PipelineBuildType{
 			BuildType:                buildType,
 			Pro:                      pro,
 			InternalParameters:       builddefinitions.SLSAPipelineInternalParameters,
 			AddTaskDescriptorContent: builddefinitions.AddSLSATaskDescriptor,
 		}, nil
-	case tektonBuildType:
+	case builddefinitions.TektonBuildType:
 		return builddefinitions.PipelineBuildType{
 			BuildType:                buildType,
 			Pro:                      pro,

diff --git a/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go b/pkg/chains/formats/slsa/v2alpha2/internal/taskrun/taskrun.go
@@ -104,13 +104,13 @@ func byproducts(tro *objects.TaskRunObject) ([]slsa.ResourceDescriptor, error) {
 
 func getBuildDefinition(buildType string, tro *objects.TaskRunObject) (builddefinitions.TaskBuildType, error) {
 	switch buildType {
-	case "https://tekton.dev/chains/v2/slsa":
+	case builddefinitions.SlsaBuildType:
 		return builddefinitions.TaskBuildType{
 			BuildType:          buildType,
 			Tro:                tro,
 			InternalParameters: builddefinitions.SLSATaskInternalParameters,
 		}, nil
-	case "tekton-build-type":
+	case builddefinitions.TektonBuildType:
 		return builddefinitions.TaskBuildType{
 			BuildType:          buildType,
 			Tro:                tro,