Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] include jkhelil as approver #2417

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[main] include jkhelil as approver #2417

merged 1 commit into from
Nov 21, 2024

Conversation

jkandasa
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@jkandasa
include jkhelil as approver
1b66ce9 
Signed-off-by: Jeeva Kandasamy <[email protected]>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 21, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@PuneetPunamiya
Copy link
Member

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@PuneetPunamiya: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@vdemeester
Copy link
Member

/approve
/lgtm
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [savitaashture,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 219635d into tektoncd:main Nov 21, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture approved these changes

@jkhelil jkhelil Awaiting requested review from jkhelil

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@vdemeester vdemeester

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkandasa @PuneetPunamiya @tekton-robot @vdemeester @savitaashture