Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python lint action #111

Merged
merged 1 commit into from
Nov 24, 2023
Merged

add python lint action #111

merged 1 commit into from
Nov 24, 2023

Conversation

rndmh3ro
Copy link
Contributor

No description provided.

schurzi
schurzi approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use ruff?

@rndmh3ro
Copy link
Contributor Author

why not use ruff?

There's no specific reason, I just happened to start using black for this project.
We can add ruff, too.

@rndmh3ro rndmh3ro merged commit 8b7df25 into main Nov 24, 2023
2 checks passed
@rndmh3ro rndmh3ro deleted the python_linting branch November 24, 2023 08:14
@schurzi
Copy link
Contributor

schurzi commented Nov 24, 2023

We can add ruff, too.

I was not thinking about adding, but about substituting. Since ruff does the same as black, only faster.

@rndmh3ro
Copy link
Contributor Author

Ruff does a lot more than black, so I'd rather keep these separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schurzi schurzi schurzi approved these changes

@michaelamattes michaelamattes Awaiting requested review from michaelamattes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndmh3ro @schurzi