Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

feat: grafana_organization module and simplify vars-structure #17

Merged
merged 21 commits into from
Nov 1, 2023
Merged

feat: grafana_organization module and simplify vars-structure #17

merged 21 commits into from
Nov 1, 2023

Conversation

Nemental
Copy link
Contributor

@Nemental Nemental commented Oct 11, 2023

  • added community.grafana.grafana_organization task
  • added community.grafana.grafana_organization_user task (disabled, because community.grafana 1.6.0 required)
  • fixed ansible role downloads badge
  • fixed and beautify readme variables table
  • minify yaml
  • ⚠️ removed subelements('x_object') filter from several loops
    • I don't understand the benefit of this. In some places it isn't used at all and in other places it is only used for the name, although you can replace this with the key name. I'm also wondering why x_object is defined as a list.
    • For further support of x_object, I could leave the subelements there for now and set a default for name if it isn't defined.

@Nemental Nemental marked this pull request as ready for review October 12, 2023 10:23
@rndmh3ro
Copy link
Collaborator

Thanks for this PR, looks goot to me.

⚠️ removed subelements('x_object') filter from several loops

The idea behind this was that you could create several objects with the same configuration but only had to write the configuration once, e.g. like this:

grafana_teams:
  - team_object:
     - team_1
     - team_2
     users:
      - foo
      - bar

We initially did this in the icinga-director collection but the usage of it never really took off. So I'm fine with removing it. This however is a breaking change that we'll need to address.

tasks/main.yml Outdated Show resolved Hide resolved
@Nemental Nemental requested a review from rndmh3ro October 17, 2023 11:54
@Nemental Nemental mentioned this pull request Oct 17, 2023
1 task
@Nemental
Copy link
Contributor Author

@rndmh3ro can you please take a look on this PR? :)
After the merge I can finalize #18 and merge it too. Thanks!

@rndmh3ro rndmh3ro merged commit a16127e into telekom-mms:main Nov 1, 2023
2 of 4 checks passed
@Nemental Nemental deleted the feature/orga-and-simplify branch November 1, 2023 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants