This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: grafana_organization module and simplify vars-structure #17
Merged
rndmh3ro
merged 21 commits into
telekom-mms:main
from
Nemental:feature/orga-and-simplify
Nov 1, 2023
Merged
feat: grafana_organization module and simplify vars-structure #17
rndmh3ro
merged 21 commits into
telekom-mms:main
from
Nemental:feature/orga-and-simplify
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
added
enhancement
New feature or request
breaking
hacktoberfest-accepted
labels
Oct 17, 2023
Thanks for this PR, looks goot to me.
The idea behind this was that you could create several objects with the same configuration but only had to write the configuration once, e.g. like this:
We initially did this in the icinga-director collection but the usage of it never really took off. So I'm fine with removing it. This however is a breaking change that we'll need to address. |
rndmh3ro
reviewed
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
community.grafana.grafana_organization
taskaddedcommunity.grafana.grafana_organization_user
task (disabled, because community.grafana 1.6.0 required)subelements('x_object')
filter from several loopsname
. I'm also wondering whyx_object
is defined as a list.x_object
, I could leave the subelements there for now and set a default forname
if it isn't defined.