Make MTU optional for VRFrouteconfiguration #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watzkuh
requested review from
MaxRink,
Cellebyte,
chdxD1 and
schrej
as code owners
|
Is this safe to just omit? Took a brief look at the code, and at least in one location defaulting doesn't seem to be properly implemented: https://github.com/telekom/das-schiff-network-operator/blob/main/pkg/nl/layer3.go#L191 |
|
I'm not entirely sure. I'm only assuming it because from what I can see we have the value set for only 3 of our own VRFRouteConfigurations and unset for 816 of them* and I was hoping they weren't all broken. (*assuming I greped correctly) |
|
@schrej good catch, that line should also contain |
|
@watzkuh If you could change the line mentioned by Jakob from |
|
@chdxD1 Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.