Re-Attach/Update BPF program on existing VRF interfaces and Fix Monitoring #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest moving the bpf monitoring into the monitoring directory. |
|
Confirmed working on dev Cluster 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the BPF program was only re-attached to the onlyBPFInterfaces of the config. Existing VRF interfaces weren't reconciled and the BPF wasn't re-added to them. This is now fixed and the BPF program is re-attached if the IDs do not match.
In this PR also the monitoring of eBPF maps get fixed by copying the value of the for-loop into a separate variable, which is a known Go problem (which gets fixed in 1.21 which we don't use yet)