Skip to content

Commit

Permalink
Use PhoneLib 8.13.52 (adapting also new meta data bug of DE 176 range…
Browse files Browse the repository at this point in the history
…) and prepare release (#92)

Use PhoneLib 8.13.52 (adapting also new meta data bug of DE 176 range) and prepare release
Meta Data bug reported: https://issuetracker.google.com/issues/384186540
  • Loading branch information
Anrufliste authored Dec 15, 2024
1 parent a97ed61 commit 3fa1862
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 21 deletions.
3 changes: 3 additions & 0 deletions REPORTED_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ Google stated it is aware and will bring changes after investigation that users

Google [fixed](https://github.com/google/libphonenumber/pull/3671/files#diff-5061a7d3c54ba589aacce00dcee1ce92e098c40034749bcae4c8a4780bb40233) it with [8.13.48](https://github.com/google/libphonenumber/pull/3671) on 16.10.2024
While normal mobile numbers are now aligend, voicemail numbers length is still problematic (BUG needs to be reported!).

### 2024-12-14 - [Metadata Update of 8.13.52 for DE mobile 176 range is invalid](https://issuetracker.google.com/issues/384186540)
While Google had corrected mobile 17x range with prior feedback, they introduced an inconsistency with the last DE meta data update.
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<artifactId>normalizer</artifactId>
<name>Phonenumber Normalizer</name>
<description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
<version>1.3.5-SNAPSHOT</version>
<version>1.3.5</version>
<packaging>jar</packaging>
<url>https://github.com/telekom/phonenumber-normalizer</url>

Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>libphonenumber</artifactId>
<version>8.13.51</version>
<version>8.13.52</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -150,7 +150,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>geocoder</artifactId>
<version>2.245</version>
<version>2.246</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1816,25 +1816,25 @@ class IsValidNumberTest extends Specification {
//
// 0176
//
"01760" | "DE" | [false, false, false, false, false, false, false, false]
"01761" | "DE" | [false, false, false, false, false, false, false, false]
"01762" | "DE" | [false, false, false, false, false, false, false, false]
"017630" | "DE" | [false, false, false, false, false, false, false, false]
"017631" | "DE" | [false, false, false, false, false, false, false, false]
"017632" | "DE" | [false, false, false, false, false, false, false, false]
"01760" | "DE" | [false, true, false, false, false, true, false, false]
"01761" | "DE" | [false, true, false, false, false, true, false, false]
"01762" | "DE" | [false, true, false, false, false, true, false, false]
"017630" | "DE" | [false, true, false, false, false, true, false, false]
"017631" | "DE" | [false, true, false, false, false, true, false, false]
"017632" | "DE" | [false, true, false, false, false, true, false, false]
// 017633 is reserved for voicemail - see tests below
"017634" | "DE" | [false, false, false, false, false, false, false, false]
"017635" | "DE" | [false, false, false, false, false, false, false, false]
"017636" | "DE" | [false, false, false, false, false, false, false, false]
"017637" | "DE" | [false, false, false, false, false, false, false, false]
"017638" | "DE" | [false, false, false, false, false, false, false, false]
"017639" | "DE" | [false, false, false, false, false, false, false, false]
"01764" | "DE" | [false, false, false, false, false, false, false, false]
"01765" | "DE" | [false, false, false, false, false, false, false, false]
"01766" | "DE" | [false, false, false, false, false, false, false, false]
"01767" | "DE" | [false, false, false, false, false, false, false, false]
"01768" | "DE" | [false, false, false, false, false, false, false, false]
"01769" | "DE" | [false, false, false, false, false, false, false, false]
"017634" | "DE" | [false, true, false, false, false, true, false, false]
"017635" | "DE" | [false, true, false, false, false, true, false, false]
"017636" | "DE" | [false, true, false, false, false, true, false, false]
"017637" | "DE" | [false, true, false, false, false, true, false, false]
"017638" | "DE" | [false, true, false, false, false, true, false, false]
"017639" | "DE" | [false, true, false, false, false, true, false, false]
"01764" | "DE" | [false, true, false, false, false, true, false, false]
"01765" | "DE" | [false, true, false, false, false, true, false, false]
"01766" | "DE" | [false, true, false, false, false, true, false, false]
"01767" | "DE" | [false, true, false, false, false, true, false, false]
"01768" | "DE" | [false, true, false, false, false, true, false, false]
"01769" | "DE" | [false, true, false, false, false, true, false, false]

//
// 0177
Expand Down

0 comments on commit 3fa1862

Please sign in to comment.