feat: added mongo db query required for offset-based sse #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage querying on mongo
mherwig
requested review from
Th3Shadowbroker,
julian-spierefka and
WRichter72
and removed request for
a team
|
mherwig
requested review from
Schnix84 and
hegbers
and removed request for
Th3Shadowbroker and
julian-spierefka
Schnix84
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature of SSE (Server-Sent Events) being based on the HTTP protocol, data loss cannot be completely ruled out. For example, if a client abruptly disconnects from an SSE connection, it is possible that data might be successfully written to the TCP buffer of the underlying operating system, but never reach the client. The server, however, has no direct way of responding to any outstanding acknowledgements from the client and assumes in such cases that the message was successfully delivered. This can lead to data loss, which we aim to prevent within the scope of this epic.
To address this, this PR introduces a new MongoDB query which allows to search for entries that are newer than a given timestamp. This is a requirment for offset-based event-streaming in Horizon Pulsar.