fix: add hidden input with name attribute #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: felix-ico <[email protected]>
acstll
reviewed
Nov 23, 2023
| @@ -208,6 +208,8 @@ export class DropdownSelect { | |||
| @Prop() ariaLabelSelected?: string = 'selected'; | |||
| /** (optional) Text displayed in high contrast mode only to indicate disabled state */ | |||
| @Prop() hcmLabelDisabled?: string = 'this field is disabled'; | |||
| /** (optional) is the element used in a form */ | |||
| @Prop() formAssociated?: boolean = false; | |||
There was a problem hiding this comment.
I wouldn't call this formAssociated because it's not exactly the same as the standard static method.
I would actually not use any prop at all and just render the hidden input, always. The button has similar "hacks"… What do you think?
There was a problem hiding this comment.
makes sense, will do that instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #2173