Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prop for removing tabindex #2215

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix: add prop for removing tabindex #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35e2252
fix: add prop for removing tabindex
Nov 21, 2023
68532d7
test(visual): update snapshots (#2216)
github-actions[bot] Nov 22, 2023
9c23883
docs: add new props to storybook
Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/components/src/components/tab-panel/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

## Properties

| Property | Attribute | Description | Type | Default |
| -------- | --------- | ----------------------------------------------------------------------------------- | -------------------- | ----------- |
| `size` | `size` | <span style="color:red">**[DEPRECATED]**</span> - no more size difference<br/><br/> | `"large" \| "small"` | `'small'` |
| `small` | `small` | <span style="color:red">**[DEPRECATED]**</span> - no more size difference<br/><br/> | `boolean` | `false` |
| `styles` | `styles` | (optional) Injected CSS styles | `string` | `undefined` |
| Property | Attribute | Description | Type | Default |
| --------------- | ---------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------- | ----------- |
| `size` | `size` | <span style="color:red">**[DEPRECATED]**</span> - no more size difference<br/><br/> | `"large" \| "small"` | `'small'` |
| `small` | `small` | <span style="color:red">**[DEPRECATED]**</span> - no more size difference<br/><br/> | `boolean` | `false` |
| `styles` | `styles` | (optional) Injected CSS styles | `string` | `undefined` |
| `tabbablePanel` | `tabbable-panel` | (optional) adds tab-index="0" to the panel, set to false to exclude the tab-panel from the tab sequence, e.g. if the first element in the panel is a focusable button | `boolean` | `true` |


## Shadow Parts
Expand Down
10 changes: 9 additions & 1 deletion packages/components/src/components/tab-panel/tab-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export class TabPanel {
/** (optional) size */
/** @deprecated - no more size difference */
@Prop() size: 'small' | 'large' = 'small';
/** (optional) adds tab-index="0" to the panel, set to false to exclude the tab-panel from the tab sequence, e.g. if the first element in the panel is a focusable button */
@Prop() tabbablePanel?: boolean = true;
/** (optional) Injected CSS styles */
@Prop() styles?: string;

Expand All @@ -43,12 +45,18 @@ export class TabPanel {
}
}

setTabIndex() {
if (this.tabbablePanel === true) {
return { tabindex: '0' };
}
}

render() {
return (
<Host
id={`scale-tab-panel-${this.generatedId}`}
role="tabpanel"
tabindex="0"
{...this.setTabIndex()}
>
{this.styles && <style>{this.styles}</style>}
<div part="tab-panel" class="tab-panel">
Expand Down
2 changes: 2 additions & 0 deletions packages/storybook-vue/stories/components/tab-navigation/TabNav.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import {
Description,
} from '@storybook/addon-docs';
import ScaleTabNav from './ScaleTabNav.vue';
import TabPanel from './TabPanel.vue';

<Meta
title="Components/Tab Navigation"
component={ScaleTabNav}
subcomponents={{ 'Scale Tab Panel': TabPanel }}
argTypes={{
styles: {
table: {
Expand Down
17 changes: 17 additions & 0 deletions packages/storybook-vue/stories/components/tab-navigation/TabPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<script>
export default {
name: 'Tab Panel',
props: {
styles: { type: String },
tabbable: { type: Boolean, default: 'true',
argTypes:{
table: {
type: { summary: 'string' },
},
description: `(optional) Injected styles`,
control: { type: null },
},
},
}
};
</script>