no userInfo for profile-menu #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tshimber
changed the title
tshimber
force-pushed
the
feature-profile-menu
branch
from
0d8e6d6 to
f17b04e
Compare
|
LGTM! |
amir-ba
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2331
Fixes #2293
telekom-profile-menu component was failing in case userInfo is not provided. The check for empty prop is added.
UPD: no serviceLinks + hideLoginSettings case fixed.
UPD: lil css nesting fix for nav item inside profile menu added
@amir-ba we could discuss how css should be refactored for components having shadow: false. now looks like muddle which i'm afraid to touch