feat: aria-details added to diff input types #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amir-ba
reviewed
Oct 24, 2024
| @@ -204,7 +204,7 @@ export const RangeTemplate = (args, { argTypes }) => ({ | |||
| args={{ | |||
| value: '2020-12-31', | |||
| label: 'Standard', | |||
| placeholder: 'Select date' | |||
| placeholder: 'Select date', | |||
There was a problem hiding this comment.
extra comma can be removed
| @@ -290,7 +291,7 @@ duet-date-picker { | |||
| label: 'With Error', | |||
| invalid: true, | |||
| helperText: 'something is wrong', | |||
| placeholder: 'select date' | |||
| placeholder: 'select date', | |||
There was a problem hiding this comment.
this also has a unneeded change
| @@ -13,8 +13,8 @@ import { action } from '@storybook/addon-actions'; | |||
| export const Template = (args, { argTypes }) => ({ | |||
| components: { ScaleDropdownSelect }, | |||
| props: { | |||
| itemProps: { default: {} }, | |||
| ...ScaleDropdownSelect.props, | |||
| itemProps: { default: {} }, | |||
There was a problem hiding this comment.
extra whitespace in from of itemProps
| @@ -54,8 +54,8 @@ export const Template = (args, context) => ({ | |||
| :disabled="itemProps[index]?.disabled" | |||
| ></scale-radio-button> | |||
| </scale-radio-button-group> | |||
| ` | |||
| }) | |||
| `, | |||
There was a problem hiding this comment.
extra comma again :) . is this being added from prettier?
amir-ba
reviewed
Oct 24, 2024
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2356
AriaDetailsId added to different input types