This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
Adds a basic authentication module that adds a real identity to the logs. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogs. Works only when a .aur file is used, since it requires code executed by a base file to hook the authentication process. In the medium term, we need to create our own client so that we can hook auth + updates for all methods without going through .aur files that may or may not be imported.
|
looks good (thumbsup) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works only when a .aur file is used, since it requires code executed by a
base file to hook the authentication process. In the medium term, we need
to create our own client so that we can hook auth + updates for all methods
without going through .aur files that may or may not be imported.
This pull request is only to solicit feedback; we'll leave it in a separate branch that we merge with master to create the tellapart branch going forward.
@steveniemitz @dmontauk @tonyd3