Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more consistency and use bytes whenever possible #114

Closed
wants to merge 5 commits into from
Closed

fix: more consistency and use bytes whenever possible #114

wants to merge 5 commits into from

Conversation

facundomedica
Copy link
Collaborator

No description provided.

@facundomedica facundomedica marked this pull request as draft April 10, 2024 17:11
tkernell
tkernell reviewed Apr 11, 2024
View reviewed changes
x/bridge/keeper/keeper.go Outdated Show resolved Hide resolved
@facundomedica facundomedica marked this pull request as ready for review April 18, 2024 11:34
@themandalore themandalore requested a review from akremstudy April 18, 2024 17:13
akremstudy
akremstudy reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@akremstudy akremstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hold off on this until we decide what type to go with since this pr is breaking hardhat tests?

@brendaloya
Copy link
Contributor

We will reopen it later with extra changes to make everything work with the bridge.

@brendaloya brendaloya closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akremstudy akremstudy akremstudy left review comments

@tkernell tkernell tkernell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@facundomedica @brendaloya @tkernell @akremstudy