fix: audit issues #4-10 #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danflo27
commented
Jan 8, 2025
danflo27
commented
- Update reporter AnteHandler to handle MsgExec explicitly
- Update CalculateBlockProvision to mint coins using Minter.BondDenom instead of DefaultBondDenom
- Return nil early if coins.AmountOf(layer.BondDenom) is zero to avoid constructing invalid transactions + small gas optimization
- Add validation in the CreateReporter function to ensure msg.CommissionRate is greater than or equal to params.MinCommissionRate
- Rename var in CreateReporter function (minTrb -> minLoya)
- Implement a validation for Params that will ensure the MinStakeAmount has been provided
- Implement a validation in Validate function of the GenesisState in the Oracle module
…mmission rate max at 1
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
akremstudy
reviewed
Jan 15, 2025
…k for empty querydata
|
issue reference #s are from audit repo |
* remove unused returned errors in proposal_handler * op addr used in init sig, and evm addr registered only once
* remove unused returned errors in proposal_handler * op addr used in init sig, and evm addr registered only once * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.