Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip manual feeds when listening for tips #745

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Skip manual feeds when listening for tips #745

merged 5 commits into from
Feb 12, 2024

Conversation

akremstudy
Copy link
Collaborator

@akremstudy akremstudy commented Feb 7, 2024

Summary

Add a skip manual feed flag to bypass feeds that require manual value input to avoid the tip listener suggesting that type of feed especially when it has the biggest tip.

Steps Taken to QA Changes

Checklist

This pull request is:

  • A documentation error, docs update, or typographical error fix
    • No tests or issue needed
  • A code fix
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a bug report issue
    • Please include tests. Fixes without tests will not be accepted unless it's related to the documentation only.
    • Please make sure docs are updated if need be
  • A feature implementation
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a feature enhancement issue
    • Please include tests
    • Please make sure docs updates are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

@akremstudy akremstudy requested a review from 0xSpuddy February 12, 2024 15:09
Copy link
Contributor

@0xSpuddy 0xSpuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on sepolia, and works great!

@0xSpuddy 0xSpuddy merged commit 335ed38 into main Feb 12, 2024
4 checks passed
@0xSpuddy 0xSpuddy deleted the skip_manual_feeds branch March 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants