USDM, wUSDM, sDAI feeds and new CurveFi price source #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akremstudy
approved these changes
Mar 12, 2024
|
Amazing @akremstudy thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed to add feeds and a new source for pulling prices from curve. @akremstudy asking for your review on the new
curvefipricesource. (logic / magic in the get_price function)It's a different curve api from the one we integrated years ago: https://docs.curve.fi/curve-api/curve-prices/
The feeds are working the way we want, but thinking we should consolidate these sources (the curves and the uniswaps at least) and make more universal at some point in the future too.