Honor open ranges in date_bin_table #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I was unpacking the endpoints of the range into a naive BETWEEN check, ranges with open ends (i.e. non-inclusive) were not honored in the final output. Adding a range inclusion check on the JOIN fixes the issue. Added a new test query to verify the correct behavior.
jasonmp85
force-pushed
the
fix_open_ranges
branch
from
6a5260c to
9d840dc
Compare
ChuckHend
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I was unpacking the endpoints of the range into a naive BETWEEN check, ranges with open ends (i.e. non-inclusive) were not honored in the final output.
Adding a range inclusion check on the JOIN fixes the issue. Added a new test query to verify the correct behavior.
Fixes #19.