Add make_view_incremental, tests, documentation, etc. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had some interrupts since opening this, forgot I did open it, and was pleasantly surprised today that I'd already written a function I know I'll need. Getting this up to speed! |
ChuckHend
approved these changes
Sep 25, 2024
jasonmp85
force-pushed
the
make_view_incremental
branch
2 times, most recently
from
861630c to
bfc8998
Compare
Committing this functional subset to get the PR open and start working code into a release.
jasonmp85
force-pushed
the
make_view_incremental
branch
from
bfc8998 to
9331b3f
Compare
jasonmp85
added a commit
that referenced
this pull request
Sep 26, 2024
Committing this functional subset to get the PR open and start working code into a release.
|
Hey there, thanks for this! I'm very excited to try this out! But seeing that you didn't add this to the readme or the recent release notes, do you consider this "unstable"? As in, e.g. I shouldn't open issues if I encounter any problems, and shouldn't expect it to "just work"? |
No, it's not considered unstable. We do have one issue being fixed in a newer release of IVM that I'm releasing shortly. I'll update the install instructions so you know what to do there, too. I'll keep you posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing this functional subset to get the PR open and start working code into a release.