Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry(v1): save Configuration and LoadableLibraries on publish #551

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Dec 7, 2023

No description provided.

Copy link
Contributor

@ianstanton ianstanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrmiguel Looks good, just a couple of suggestions and it looks like there's a test failure to clean up

registry/src/routes/extensions.rs Outdated Show resolved Hide resolved
registry/src/v1/extractor.rs Outdated Show resolved Hide resolved
registry/src/v1/extractor.rs Outdated Show resolved Hide resolved
@ianstanton ianstanton self-requested a review December 8, 2023 16:13
@vrmiguel vrmiguel merged commit d022d84 into main Dec 8, 2023
4 of 5 checks passed
@vrmiguel vrmiguel deleted the tem-2540 branch December 8, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants