registry: allow publishing extensions of several Postgres versions #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianstanton
reviewed
Dec 27, 2023
Comment on lines
+115
to
+139
| Some(ext) | ||
| if ext == "json" | ||
| && path.file_stem().and_then(OsStr::to_str) == Some("manifest") => | ||
| { | ||
| // We're now iterating through manifest.json | ||
| let manifest = decompress_file(&mut entry, entry_size)?; | ||
| let manifest: Manifest = serde_json::from_str(&manifest) | ||
| .with_context(|| "Failed to deserialize manifest.json")?; | ||
|
|
||
| manifest_json = Some(manifest); | ||
| } | ||
| Some(_) | None => continue, | ||
| } | ||
| } | ||
|
|
||
| Ok(control_files) | ||
| anyhow::ensure!( | ||
| manifest_json.is_some(), | ||
| "Failed to find manifest.json in archive being uploaded" | ||
| ); | ||
|
|
||
| Ok(ExtractedArchive { | ||
| control_files, | ||
| manifest: manifest_json.unwrap(), | ||
| }) | ||
| } |
There was a problem hiding this comment.
@vrmiguel Is this just to make sure a manifest.json file is included in the tar.gz? Are we doing anything with the manifest.json?
There was a problem hiding this comment.
We're using the Manifest to check which Postgres version the extension was built for
ianstanton
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.