registry: add default value for pg_version if not found in manifest
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
requested review from
EvanHStanton,
ianstanton and
theory
as code owners
theory
approved these changes
Apr 1, 2024
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publish endpoint would occasionally fail with
Failed to decompress Trunk archive(PLAT-112). It appears this is because of how we fetch the Postgres version a package was built for: checking forpg_versionwithinmanifest.json.Older versions of Trunk CLI did not append this info which caused the endpoint to fail. The new behavior is to assume the Postgres version is 15 since, if the user's Trunk CLI was old enough to not append this info, it'd also not be enough to build the extension for any other version other than 15.