readme: also replace relative Markdown links, not just relative images #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sjmiller609
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial solution had perhaps a bit of tunnel vision by focusing on replacing only relative Markdown images, while it rather should replace all of the Markdown links we can find, images or not.
One example where this proved to be an issue is in https://pgt.dev/extensions/pg_partman. Since their README has stuff like
[pg_partman.md](doc/pg_partman.md), pgt.dev incorrectly linked that to https://pgt.dev/extensions/doc/pg_partman.md.With the changes proposed in this PR, pgt.dev would now link to https://raw.githubusercontent.com/pgpartman/pg_partman/master/doc/pg_partman.md instead.