Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: don't create Postgres transactions #720

Merged
merged 1 commit into from
Jun 18, 2024
Merged

registry: don't create Postgres transactions #720

merged 1 commit into from
Jun 18, 2024

Conversation

vrmiguel
Copy link
Member

No description provided.

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-720.d2qgksbj4k37j8.amplifyapp.com

theory
theory approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but just to be sure I understand, is this because these are all single queries that don't need to gate anything else? If so, I suggest writing up the reasoning in the commit message.

@vrmiguel vrmiguel merged commit 0a851e4 into main Jun 18, 2024
5 checks passed
@vrmiguel vrmiguel deleted the pg-tx-registry branch June 18, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theory theory theory approved these changes

@EvanHStanton EvanHStanton Awaiting requested review from EvanHStanton

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrmiguel @theory