Get rid of the cycle in this build system #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmp85
requested review from
ianstanton,
theory,
vrmiguel and
ChuckHend
as code owners
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
(This will update the existing trunk test images to have the latest pg17-capable trunk in them, which I can then use to publish 17-compatible extensions) |
ChuckHend
approved these changes
Nov 14, 2024
shahadarsh
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trunk needs this image to have the latest trunk in it. Rather than get it from its own repo, or cargo, it depends on
tembo-images, which installs trunk there. But those images install extensions usingtrunk, which cannot be published for pg17 until the trunk publish step is complete, which depends on those same pg17 images.This just forces the latest trunk within the tembo-trunk-test images themselves, sidestepping the need to upgrade the
cpng/slimimages and solving what appears to be a boostrapping problem.