Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate extension files #844

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Validate extension files #844

merged 4 commits into from
Dec 13, 2024

Conversation

vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Dec 12, 2024

If the install_command is incorrect, Trunk CLI builds the extension with an invalid Trunk archive, silently. This PR aims to alert us of such instances, specially when building from CI

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-844.d2qgksbj4k37j8.amplifyapp.com

cli/src/commands/containers.rs Outdated Show resolved Hide resolved
cli/src/commands/containers.rs Show resolved Hide resolved
cli/src/commands/containers.rs Outdated Show resolved Hide resolved
@vrmiguel vrmiguel merged commit 2edc886 into main Dec 13, 2024
3 of 4 checks passed
@vrmiguel vrmiguel deleted the tem-2593 branch December 13, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants