Refactor remaining core extension build scripts #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
theory
added a commit
that referenced
this pull request
Dec 13, 2024
theory
force-pushed
the
pg17-more-core
branch
from
c5e6fe2 to
08b480c
Compare
theory
requested review from
ianstanton,
vrmiguel and
ChuckHend
as code owners
theory
added a commit
that referenced
this pull request
Dec 13, 2024
As in 8d2a1e7 (#838) make a shallow clone of the Git repo and use `USE_PGXS=1` to build and install against the system Postgres instead of configuring the cloned source, eliminating the need to move files in the `install_command`. Also, run the `install_command` with `bash` instead of `sh`, for better shell semantics. Required for lines like this to work: ```sh rm "$(pg_config --sharedir)"/extension/plperlu{--*,.*} ``` Make minor edits to the jsonb_plperl, plperl, and pltcl build scripts so they fire again and properly remove unwanted files.
theory
force-pushed
the
pg17-more-core
branch
from
08b480c to
a6e83cf
Compare
theory
added a commit
that referenced
this pull request
Dec 13, 2024
As in 8d2a1e7 (#838) make a shallow clone of the Git repo and use `USE_PGXS=1` to build and install against the system Postgres instead of configuring the cloned source, eliminating the need to move files in the `install_command`. Also, run the `install_command` with `bash` instead of `sh`, for better shell semantics. Required for lines like this to work: ```sh rm "$(pg_config --sharedir)"/extension/plperlu{--*,.*} ``` Make minor edits to the jsonb_plperl, plperl, and pltcl build scripts so they fire again and properly remove unwanted files.
theory
force-pushed
the
pg17-more-core
branch
from
a6e83cf to
2d59170
Compare
vrmiguel
approved these changes
Dec 13, 2024
As in 8d2a1e7 (#838) make a shallow clone of the Git repo and use `USE_PGXS=1` to build and install against the system Postgres instead of configuring the cloned source, eliminating the need to move files in the `install_command`. Also, run the `install_command` with `bash` instead of `sh`, for better shell semantics. Required for lines like this to work: ```sh rm "$(pg_config --sharedir)"/extension/plperlu{--*,.*} ``` Make minor edits to the jsonb_plperl, plperl, and pltcl build scripts so they fire again and properly remove unwanted files.
theory
force-pushed
the
pg17-more-core
branch
from
2d59170 to
9a888ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in 8d2a1e7 (#838) make a shallow clone of the Git repo and use
USE_PGXS=1to build and install against the system Postgres instead of configuring the cloned source, eliminating the need to move files in theinstall_command.Also, run the
install_commandwithbashinstead ofsh, for better shell semantics. Required for lines like this to work:Make minor edits to the jsonb_plperl, plperl, and pltcl build scripts so they fire again and properly remove unwanted files.