Make attribute removal to actually work

templado · Mar 6, 2024 · d83fc48 · d83fc48
1 parent 9456358
commit d83fc48
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/viewmodel/ViewModelRenderer.php b/src/viewmodel/ViewModelRenderer.php
@@ -631,7 +631,7 @@ private function objectApply(DOMElement $context, object $model): void {
             }
 
             if ($result instanceof Remove || $result === false) {
-                $context->removeChild($attribute);
+                $context->removeAttributeNode($attribute);
 
                 continue;
             }

diff --git a/tests/viewmodel/ViewModelRendererTest.php b/tests/viewmodel/ViewModelRendererTest.php
@@ -1325,4 +1325,28 @@ public function b(): string {
         $this->assertEquals('b', $dom->documentElement->textContent);
     }
 
+    public function testAttributeGetsRemovedWhenRemoveSignalIsGiven(): void {
+        $dom = new DOMDocument();
+        $dom->loadXML('<root property="root" attr="foo" />');
+
+        $renderer = new ViewModelRenderer();
+
+        $renderer->render(
+            $dom->documentElement,
+            new class {
+
+                public function root(): self {
+                    return $this;
+                }
+                public function attr(): Signal {
+                    return Signal::remove();
+                }
+            }
+        );
+
+        $this->assertFalse(
+            $dom->documentElement->hasAttribute('attr')
+        );
+
+    }
 }