Skip to content

Commit

Permalink
Correct activity poller typo.
Browse files Browse the repository at this point in the history
Fixes #16.
  • Loading branch information
robholland committed May 24, 2024
1 parent c655d7b commit 21f7b29
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ kubectl run benchmark-worker --image ghcr.io/temporalio/benchmark-workers:main \
--env "TEMPORAL_NAMESPACE=default" \
--env "TEMPORAL_TASK_QUEUE=benchmark" \
--env "TEMPORAL_WORKFLOW_TASK_POLLERS=16" \
--env "TEMPORAL_WORKFLOW_ACTIVITY_TASK_POLLERS=8"
--env "TEMPORAL_ACTIVITY_TASK_POLLERS=8"
```

However, we suggest you use a deployment for workers rather than `kubectl run` so that you can collect metrics via prometheus. We provide an [example deployment spec](./deployment.yaml) for you to customize to your requirements. Once you have edited the environment variables in the deployment.yaml you can create the deployment with `kubectl apply -f ./deployment.yaml`.
Expand Down
2 changes: 1 addition & 1 deletion deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
value: "benchmark"
- name: TEMPORAL_WORKFLOW_TASK_POLLERS
value: "16"
- name: TEMPORAL_WORKFLOW_ACTIVITY_TASK_POLLERS
- name: TEMPORAL_ACTIVITY_TASK_POLLERS
value: "8"
restartPolicy: Always
---
Expand Down

0 comments on commit 21f7b29

Please sign in to comment.