Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify uncorrect db name. #210

Closed
wants to merge 1 commit into from
Closed

Conversation

dakele123
Copy link

What was changed

modify the uncorrect db name; which should be postgres12

Why?

Checklist

  1. Closes [Bug] can not launch temporalio when using multirole #209

  2. How was this tested:
    test in my pc

  3. Any docs updates needed?
    no docs needed.

@dakele123 dakele123 requested a review from a team as a code owner June 18, 2024 11:27
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
All committers have signed the CLA.

@robholland
Copy link
Contributor

Looks good, thank you :) Please sign the CLA and I'll get this merged.

@gregbrowndev
Copy link

gregbrowndev commented Sep 12, 2024

Btw I also had to bump the grafana version as some of the dashboards didn't work properly.

In deployment/grafana/Dockerfile:

FROM grafana/grafana:11.2.0
ADD ./provisioning /etc/grafana/provisioning
ADD ./config.ini /etc/grafana/config.ini
ADD ./dashboards /var/lib/grafana/dashboards

also you can update the docker compose so the tag matches the version in the Dockerfile:

  grafana:
    container_name: grafana
    image: grafana/grafana:11.2.0
    build: "./deployment/grafana"

The latest Grafana version has some useful features, like being able to explore all the metrics without having to write a query:

image

If you want to merge this PR, I can make a new one with the bumped Grafana version :) Let me know

robholland added a commit that referenced this pull request Nov 7, 2024
robholland added a commit that referenced this pull request Nov 7, 2024
@robholland
Copy link
Contributor

Fixed by #214

@robholland robholland closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] can not launch temporalio when using multirole
4 participants