Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding copy of an icon to prevent a 404 when using Safari #18

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tomwheeler
Copy link
Collaborator

What was changed

I made a copy of the apple-touch-icon.png file named apple-touch-icon-precomposed.png.

Why?

Just after starting the OMS web application, I opened my browser and discovered that the terminal window where the web application was running had a very ugly error. Upon reviewing the message, I found that it was an HTTP 404 error for the apple-touch-icon-precomposed.png file. A quick web search suggested that Safari (the browser I was using) expects a file with that name to be available and will automatically request it. Making a copy of the existing image was the easiest way of preventing this 404, which I think many developers might (like me) think was some problem with the application. Thus, suppressing that 404 will improve the developer experience.

> [email protected] dev /Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web
> vite dev

Forced re-optimization of dependencies

  VITE v5.0.13  ready in 670 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
(node:40417) ExperimentalWarning: CommonJS module /Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/node_modules/.pnpm/[email protected]/node_modules/tailwindcss/lib/lib/load-config.js is loading ES Module /Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/tailwind.config.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
SvelteKitError: Not found: /apple-touch-icon-precomposed.png
    at resolve (/Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected][email protected]/node_modules/@sveltejs/kit/src/runtime/server/respond.js:516:13)
    at resolve (/Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected][email protected]/node_modules/@sveltejs/kit/src/runtime/server/respond.js:316:5)
    at Object.eval [as handle] (/Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected][email protected]/node_modules/@sveltejs/kit/src/runtime/server/index.js:71:56)
    at Module.respond (/Users/twheeler/temp/rob-mongodb-pr/reference-app-orders-web/node_modules/.pnpm/@[email protected]_@[email protected][email protected][email protected][email protected][email protected]/node_modules/@sveltejs/kit/src/runtime/server/respond.js:313:40)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
  status: 404,
  text: 'Not Found'
}

@tomwheeler tomwheeler merged commit 1ef72e1 into main Dec 9, 2024
3 checks passed
@tomwheeler tomwheeler deleted the tw-update-for-safari-icon branch December 9, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants