Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(h2c): optional certificates for TLS #579

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

cv65kr
Copy link
Contributor

@cv65kr cv65kr commented Nov 14, 2024

Reason for This PR

In case of h2c there a no need to provide certificates with enabled TLS option

Description of Changes

If TLS is enabled certificates files are optional.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review November 14, 2024 21:53
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Nov 14, 2024
@cv65kr cv65kr marked this pull request as draft November 14, 2024 22:01
@rustatian
Copy link
Collaborator

Hey @cv65kr 👋
Thank you for the PR 👍
I see an error in the CI: https://github.com/temporalio/roadrunner-temporal/actions/runs/11846144712/job/33013137624?pr=579#step:15:9696

@cv65kr cv65kr marked this pull request as ready for review November 15, 2024 15:36
tls.go Show resolved Hide resolved
@rustatian
Copy link
Collaborator

I guess it is better to introduce an option in the TLS config, like, use_h2c: true/false. And if used, skip certificates checking and skip getClientCertificates method (just return nil based on the config).

@cv65kr
Copy link
Contributor Author

cv65kr commented Nov 15, 2024

@rustatian changed

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.06%. Comparing base (c5c2e9a) to head (8a838fa).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files          14       14           
  Lines         936      936           
=======================================
  Hits          375      375           
  Misses        518      518           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustatian rustatian merged commit fd14aaf into temporalio:master Nov 19, 2024
9 checks passed
@rustatian
Copy link
Collaborator

Thank you, @cv65kr 👍
I have a plan to release 2024.3 with that change this Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants