Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-SDK: Make PendingChildWorkflow and StartedChildWorkflow public #644

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

c-thiel
Copy link
Contributor

@c-thiel c-thiel commented Nov 23, 2023

What was changed

Make PendingChildWorkflow and StartedChildWorkflow publicly accessible.

Why?

PendingChildWorkflow and StartedChildWorkflow are unreachable pub items.
They provide additional value though in Workflows to spawn / signal / cancel child workflows and should thus be externally accessible.

I also changed the PendingChildWorkflow common visibility field to pub(crate), as the corresponding Datatype is currently also not accessible from the outside. It should be consistent for PendingChildWorkflow and StartedChildWorkflow for external users.

Checklist

  1. Closes
    None yet. Do you need one?

  2. How was this tested:

Not needed, just pub changes.

  1. Any docs updates needed?

No

@c-thiel c-thiel requested a review from a team as a code owner November 23, 2023 18:33
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Sushisource Sushisource enabled auto-merge (squash) November 28, 2023 19:02
@Sushisource Sushisource merged commit 5e2f8bd into temporalio:master Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants