Update upstream protos #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 11, 2023
cretz
reviewed
Dec 11, 2023
| option ruby_package = "Temporalio::Api::Sdk::V1"; | ||
| option csharp_namespace = "Temporalio.Api.Sdk.V1"; | ||
|
|
||
| // The name of the query to retrieve this information is `__temporal_getWorkflowMetadata`. |
There was a problem hiding this comment.
I kinda wish I paid more attention at temporalio/api#336, I would have suggested the get be removed as it's implied with queries and to use underscores to separate words like __stack_trace did.
Oh well, it'd be nice if you fixed but I suppose not required since I technically marked approved.
There was a problem hiding this comment.
At this point is just a comment in the repo, so I could use __temporal_workflow_metadata in the implementation, and the next time we touch the protos we fix the comment.
There was a problem hiding this comment.
@antlai-temporal - I would love this! I think it'd be much better.
Sushisource
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update api protos to the latest.
Why?
Need SDK workflow metadata message to implement
__temporal_getWorkflowMetadataquery