Don't overwrite grpc-timeout header on update requests #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
added a commit
to temporalio/sdk-python
that referenced
this pull request
Jul 23, 2024
dandavison
added a commit
to temporalio/sdk-python
that referenced
this pull request
Jul 23, 2024
cretz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#780 caused the
sdk-pythontesttests/worker/test_workflow.py::test_workflow_update_timeout_or_cancelto fail, because the grpc-timeout header set here was not honored:https://github.com/temporalio/sdk-python/blob/c4b1a019ad2627edb20a954edfd57c9ba414f3d5/tests/worker/test_workflow.py#L4482
https://github.com/temporalio/sdk-python/blob/c4b1a019ad2627edb20a954edfd57c9ba414f3d5/tests/worker/test_workflow.py#L4523
@Sushisource defer to you on the correct resolution. FWIW, this PR makes the test pass again.