Debugger Client in core #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Aug 28, 2024
Sushisource
reviewed
Aug 29, 2024
core/src/debug_client.rs
Outdated
| #[derive(Clone)] | ||
| pub struct DebugClient { | ||
| /// URL for the local instance of the debugger server | ||
| debugger_url: String, |
There was a problem hiding this comment.
This can be an actual Url type which we already depend on https://docs.rs/url/latest/url/struct.Url.html (which also has safe ways to construct paths like adding /history)
Co-authored-by: Spencer Judge <[email protected]>
Co-authored-by: Spencer Judge <[email protected]>
Co-authored-by: Spencer Judge <[email protected]>
Co-authored-by: Spencer Judge <[email protected]>
|
Closed in favor of #829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding methods for using our VSCode extension into core, so the debugger can be extended into other languages without having to reimplement these basic methods.
Drafted while I'm still working on it.