Make activity resolution payload methods return a reference #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changes the interface provided in #814 to return a
Payload
reference, as suggested in this Slack message.Why?
Provides slightly more informative error messages and makes the methods no longer require ownership of
ActivityResolution
, which is generally an ergonomic win in Rust.Checklist
Closes no issues (it's a small change so I opted not to create an issue first)
How was this tested: the standard battery of CI tests
Any docs updates needed? I don't believe so