Replace once_cell with std::sync::{OnceLock,LazyLock} #827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Replaced
once_cell
withstd::sync
Why?
Since you can already directly use
OnceLock
andLazyLock
from std without an additional crate. However, this would require raising MSVR to 1.80 because ofLazyLock
, butOnceLock
can be used from 1.70 onwards.Considering that the current approximate MSVR is
1.77
(based on GitHub Workflow) I think it won't be a big deal to raise it to1.80
.Checklist
Run
cargo test