Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace once_cell with std::sync::{OnceLock,LazyLock} #827

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Oct 6, 2024

What was changed

Replaced once_cell with std::sync

Why?

Since you can already directly use OnceLock and LazyLock from std without an additional crate. However, this would require raising MSVR to 1.80 because of LazyLock, but OnceLock can be used from 1.70 onwards.

Considering that the current approximate MSVR is 1.77 (based on GitHub Workflow) I think it won't be a big deal to raise it to 1.80.

Checklist

  1. How was this tested:
    Run cargo test

@negezor negezor requested a review from a team as a code owner October 6, 2024 18:26
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have no problem bumping the minimum ver, but the docker image version also needs to get bumped for tests to pass looks like.

Also needs a cargo fmt to pass CI, I'll do it myself later today if you don't do it first.

@Sushisource Sushisource enabled auto-merge (squash) October 10, 2024 18:55
@Sushisource Sushisource merged commit 7fe3bc5 into temporalio:master Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants