Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexus Tasks Core->Lang #860

Merged
merged 14 commits into from
Jan 13, 2025
Merged

Nexus Tasks Core->Lang #860

merged 14 commits into from
Jan 13, 2025

Conversation

Sushisource
Copy link
Member

Warning

Can't merge this until CLI gets updated. Depends on changes in server 1.26

What was changed

Add nexus task delivery and tracking

Why?

Part of Nexus functionality

Checklist

  1. Closes

  2. How was this tested:
    Integ tests

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner January 10, 2025 19:12
cretz
cretz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly only reviewed the two new exposed worker calls and the local core protos. Both LGTM.

core-api/src/errors.rs Outdated Show resolved Hide resolved
@Sushisource Sushisource merged commit 40f8327 into nexus Jan 13, 2025
4 of 6 checks passed
@Sushisource Sushisource deleted the nexus-tasks branch January 13, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sushisource @cretz @Quinn-With-Two-Ns