Cleanup worker creation for Spring Boot Auto Configuration and add validation of the explicit worker config #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation of the explicit worker config
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
from
902f4da
to
75838f0
Compare
…lidation of the explicit worker config
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
2 times, most recently
from
6e07530
to
ba7ae1b
Compare
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
12 times, most recently
from
135b583
to
15d40d9
Compare
cretz
approved these changes
Jul 18, 2022
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
5 times, most recently
from
e019e0c
to
886e36c
Compare
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
9 times, most recently
from
7c71567
to
3a3f0a7
Compare
…lidation of the explicit worker config
Spikhalskiy
force-pushed
the
spring-boot-cleanup-worker-creation
branch
from
3a3f0a7
to
ab6aa75
Compare
…lidation of the explicit worker config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up and simplifies worker creation in Spring Boot Auto Configuration.
Add validation of the explicit worker config duplicate conflicts.
Avoids conflicts with auto-discovered implementations and adds detailed logging about the conflict resolution actions that were made.
Improving #8