Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot Autoconfiguration doesn't require temporal-testing module to be in classpath anymore #1380

Merged

Conversation

Spikhalskiy
Copy link
Contributor

@Spikhalskiy Spikhalskiy commented Aug 19, 2022

Bring a level of indirection to don't require test framework classes to be in classpath for non-test functionality

Solves

Caused by: java.lang.IllegalStateException: Failed to introspect Class [io.temporal.spring.boot.autoconfigure.ServiceStubsAutoConfiguration] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@277050dc]
[12:25](https://temporaltechnologies.slack.com/archives/D029WJKUN15/p1660926322965759)
Caused by: java.lang.NoClassDefFoundError: io/temporal/testing/TestWorkflowEnvironment
	at java.base/java.lang.Class.getDeclaredMethods0(Native Method) ~[na:na]
	at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3166) ~[na:na]
	at java.base/java.lang.Class.getDeclaredMethods(Class.java:2309) ~[na:na]
	at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:467) ~[spring-core-5.3.22.jar:5.3.22]

when users don't even configure TestServer to be used.

Towards #8

… to be in classpath anymore

Bring a level of indirection to don't require test framework classes to be in classpath for non-test functionality
@Spikhalskiy Spikhalskiy enabled auto-merge (squash) August 19, 2022 19:06
@Spikhalskiy Spikhalskiy self-assigned this Aug 19, 2022
@Spikhalskiy Spikhalskiy merged commit a927dd4 into temporalio:master Aug 19, 2022
@Spikhalskiy Spikhalskiy deleted the temporal-testing-classpath branch August 23, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants