Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus callback and task validation fixes #6918

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Dec 2, 2024

What changed?

  • Fixed the callback executor to not fail a task on retryable error (a regression introduced while refactoring to support HSM callbacks)
  • No longer use ValidateNotTransitioned in task validation logic. We can deprecate the transition_count field on the state machine node proto after this.

Why?

The first fix is a simple bug fix, the second change is for unblocking the state replication efforts.

How did you test it?

Leveraged existing tests.

@bergundy bergundy requested a review from a team as a code owner December 2, 2024 21:25
@bergundy bergundy requested a review from rodrigozhou December 2, 2024 21:25
@bergundy bergundy changed the title Nexus callback and task validiation fixes Nexus callback and task validation fixes Dec 3, 2024
components/callbacks/executors.go Show resolved Hide resolved
components/callbacks/hsm_invocation.go Outdated Show resolved Hide resolved
components/callbacks/tasks.go Outdated Show resolved Hide resolved
components/callbacks/tasks.go Outdated Show resolved Hide resolved
components/nexusoperations/tasks.go Outdated Show resolved Hide resolved
components/callbacks/executors.go Outdated Show resolved Hide resolved
@bergundy bergundy merged commit 7152de4 into temporalio:main Dec 3, 2024
49 checks passed
@bergundy bergundy deleted the callback-fix branch December 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants