Update message props and use slot fallback

Co-authored-by: Ross Edfort <[email protected]>
temporalio · Aug 13, 2024 · 5e00bea · 5e00bea
1 parent 7d193ee
commit 5e00bea
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 21 deletions.
diff --git a/src/lib/holocene/table/paginated-table/api-paginated.svelte b/src/lib/holocene/table/paginated-table/api-paginated.svelte
@@ -33,8 +33,10 @@
     onSpace?: (event: KeyboardEvent) => void | undefined;
     total?: string | number;
     pageSizeSelectLabel: string;
-    emptyStateMessage: string;
-    fallbackErrorMessage: string;
+    emptyStateTitle?: string;
+    emptyStateMessage?: string;
+    errorTitle?: string;
+    errorMessage?: string;
     itemsKeyname?: string;
     previousButtonLabel: string;
     nextButtonLabel: string;
@@ -49,8 +51,10 @@
 
   export let total: string | number = '';
   export let pageSizeSelectLabel: string;
-  export let emptyStateMessage: string;
-  export let fallbackErrorMessage: string;
+  export let emptyStateTitle = '';
+  export let emptyStateMessage = '';
+  export let errorTitle = '';
+  export let errorMessage = '';
   export let itemsKeyname = 'items';
   export let previousButtonLabel: string;
   export let nextButtonLabel: string;
@@ -168,26 +172,19 @@
 
   <svelte:fragment slot="empty">
     {#if $store.loading}
-      {#if $$slots.loading}
-        <slot name="loading" />
-      {:else}
+      <slot name="loading">
         <Loading />
-      {/if}
+      </slot>
     {:else if error}
-      {#if $$slots.error}
-        <slot name="error" />
-      {:else}
-        <EmptyState title="">
-          <Alert
-            intent="error"
-            title={error?.message ?? fallbackErrorMessage}
-          />
+      <slot name="error">
+        <EmptyState title={errorTitle}>
+          <Alert intent="error" title={error?.message ?? errorMessage} />
         </EmptyState>
-      {/if}
-    {:else if $$slots.empty}
-      <slot name="empty" />
+      </slot>
     {:else}
-      <EmptyState title="" content={emptyStateMessage} />
+      <slot name="empty">
+        <EmptyState title={emptyStateTitle} content={emptyStateMessage} />
+      </slot>
     {/if}
   </svelte:fragment>
 

diff --git a/src/lib/pages/schedules.svelte b/src/lib/pages/schedules.svelte
@@ -45,7 +45,7 @@
     nextButtonLabel={translate('common.next')}
     previousButtonLabel={translate('common.previous')}
     emptyStateMessage={translate('schedules.empty-state-title')}
-    fallbackErrorMessage={translate('schedules.error-message-fetching')}
+    errorMessage={translate('schedules.error-message-fetching')}
   >
     <caption class="sr-only" slot="caption"
       >{translate('common.schedules')}</caption