Fix editable CodeBlock (#2239)

* Set editable in codemirror EditorView * Bump @codemirror/view version for readOnly bug patch
temporalio · Jul 29, 2024 · a638bce · a638bce
1 parent 944162d
commit a638bce
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -82,7 +82,7 @@
     "@codemirror/language": "^6.10.2",
     "@codemirror/legacy-modes": "^6.4.0",
     "@codemirror/state": "^6.4.1",
-    "@codemirror/view": "^6.28.5",
+    "@codemirror/view": "^6.29.0",
     "@crownframework/svelte-error-boundary": "^1.0.3",
     "@fontsource-variable/inter": "^5.0.8",
     "@fontsource/noto-sans-mono": "^5.0.9",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/lib/holocene/code-block.svelte b/src/lib/holocene/code-block.svelte
@@ -114,6 +114,7 @@
       indentOnInput(),
       bracketMatching(),
       EditorState.readOnly.of(!editable),
+      EditorView.editable.of(editable),
       EditorView.contentAttributes.of({ 'aria-label': label }),
     ];