MultiSelect component used in Event Type filter #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stevekinney
approved these changes
Jan 18, 2024
rossedfort
reviewed
Jan 18, 2024
Comment on lines
+79
to
+85
| <Checkbox | ||
| on:click={() => onOptionClick(option)} | ||
| slot="leading" | ||
| {checked} | ||
| label={option.label} | ||
| labelHidden | ||
| /> |
There was a problem hiding this comment.
Normally would agree, but we need to call onChange as well
rossedfort
reviewed
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
To support multi-select filtering of event types in the event history, such as filtering out signals and showing the rest.
You can also Select All or Clear All.
This changes the $eventCategoryFilter from a string to string[].
Screenshots (if applicable) 📸
MultiSelectEventFilter.mov
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?