Include Input for Schedules on Create/Edit and show Input on View #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
requested review from
GiantRobots,
stevekinney,
rossedfort and
a team
as code owners
stevekinney
reviewed
Mar 13, 2024
| @@ -101,8 +105,18 @@ | |||
| } | |||
| }; | |||
|
|
|||
| const isValidInput = (value: string) => { | |||
There was a problem hiding this comment.
I could be talked into pulling this utility out.
stevekinney
approved these changes
Mar 13, 2024
…completion message with running prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Add ability to include Input payloads to create or edit a schedule and view Input when viewing a Schedule.
Includes refactoring of encoding logic to split it apart from decoding logic so we can throw error before submitting update.
Also includes change of text-subtle for placeholder text.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?